bugmake - Bugs: bug #63373, make 4.4: build failure using AIX...

 
 

bug #63373: make 4.4: build failure using AIX XLC 16.1

Submitter:  djm <mccannd>
Submitted:  Wed 16 Nov 2022 11:28:00 AM UTC
   
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.4 Operating System:  POSIX-Based
Fixed Release:  4.4.1 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 16 Nov 2022 10:29:59 PM UTC, comment #2: 

Fix pushed to Git.

 Paul D. Smith <psmith>
Group administrator
Wed 16 Nov 2022 02:27:29 PM UTC, comment #1: 

Strange, I could have sworn I went through all the code and fixed this a few months ago when Dmitry was testing builds on AIX.

Will fix, thanks for the report.


diff --git a/src/main.c b/src/main.c
index 78729de1..ba92de37 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1503,7 +1503,7 @@ main (int argc, char **argv, char **envp)

         /* If this is MAKE_RESTARTS, check to see if the "already printed
            the enter statement" flag is set.  */
-        if (len == 13 && memcmp (envp[i], STRING_SIZE_TUPLE ("MAKE_RESTARTS")) == 0)
+        if (len == 13 && memcmp (envp[i], "MAKE_RESTARTS", 13) == 0)
           {
             if (*ep == '-')
               {


 Paul D. Smith <psmith>
Group administrator
Wed 16 Nov 2022 11:28:00 AM UTC, original submission:  

When using the AIX XLC V16.1 compiler to build GNU make 4.4, the following error is observed:

source='make-4.4/src/main.c' object='src/main.o' libtool=no  DEPDIR=.deps depmode=xlc /bin/sh make-4.4/build-aux/depcomp  /opt/IBM/xlc/16.1.0/bin/xlc_r -DHAVE_CONFIG_H   -Isrc -Imake-4.4/src -Ilib -Imake-4.4/lib  -DLIBDIR=\"/opt/tools/gnumake/4.4/lib\" -DLOCALEDIR=\"/opt/tools/gnumake/4.4/share/locale\"  -DINCLUDEDIR=\"/opt/tools/gnumake/4.4/include\"     -g -c -o src/main.o make-4.4/src/main.c
"make-4.4/src/main.c", line 1508.78: 1506-041 (E) The invocation of macro memcmp contains fewer arguments than are required by the macro definition.
"make-4.4/src/main.c", line 1508.26: 1506-046 (S) Syntax error.
"make-4.4/src/main.c", line 1508.26: 1506-182 (S) Arguments missing for built-in function __memcmp.

Given that the following comment exists with STRING_SIZE_TUPLE, surely STRING_SIZE_TUPLE should not be used with memcmp?

/* Only usable when NOT calling a macro: only use it for local functions.  */
#define STRING_SIZE_TUPLE(_s) (_s), CSTRLEN(_s)

 djm <mccannd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by mccannd (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-11-16 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.4.1
        Triage StatusNone Small Effort

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-02a9.
    Corresponding source code