bugmake - Bugs: bug #63333, Keep running w/o output sync on...

 
 

bug #63333: Keep running w/o output sync on temp file failure.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Mon 07 Nov 2022 10:49:05 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  4.4 Operating System:  POSIX-Based
Fixed Release:  4.4.1 Triage Status:  Medium Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 13 Nov 2022 10:05:22 PM UTC, comment #4: 

I see you worked on a different thing than I did (I did the jobserver).  I applied this with some minor changes.

Thanks!

 Paul D. Smith <psmith>
Group administrator
Mon 07 Nov 2022 11:19:01 PM UTC, comment #3: 

Thanks Dmitry.  I already implemented a change and a test for this but I'll check and see what you've got here too.

 Paul D. Smith <psmith>
Group administrator
Mon 07 Nov 2022 10:59:14 PM UTC, comment #2: 

This patch causes make to print an error message and keep running without output sync on a temp file failure.

 Dmitry Goncharov <dgoncharov>
Mon 07 Nov 2022 10:51:41 PM UTC, comment #1: 

Make treats inability to create a temporary file for output sync as fatal and aborts the build.


$ cat makefile
all:; $(info hello, world)
$ mkdir temp
$ chmod -w temp
$ # this is make from master
$ TMPDIR=temp ~/src/make/m64/make -Orecurse -j2
make: jobserver mkfifo: temp/GMfifo4536: Permission denied
make: *** create temporary file temp/Gmt5Kg2v: Permission denied.  Stop.
$
$
$ # this is make-4.3
$ TMPDIR=temp ~/src/make/4.3/make -Orecurse -j2
hello, world
make: 'all' is up to date.
$
$ # this is make with this patch
$ TMPDIR=temp ~/src/make/l64/make -Orecurse -j2
make: jobserver mkfifo: temp/GMfifo4577: Permission denied
make: Cannot create temporary file temp/Gm7G9ZwF: Permission denied
make: Cannot open output-sync lock file, suppressing output-sync.
hello, world
make: 'all' is up to date.



 Dmitry Goncharov <dgoncharov>
Mon 07 Nov 2022 10:49:05 PM UTC, original submission:  

.

 Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53937:  sv63333_test.diff added by dgoncharov (3KiB - application/octet-stream)
file #53938:  sv63333_fix.diff added by dgoncharov (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-11-13 psmith StatusNone Fixed
        Open/ClosedOpen Closed
        Component Version4.4.1 4.4
        Fixed ReleaseNone 4.4.1
        Triage StatusNone Medium Effort
    2022-11-07 dgoncharov Attached File- Added sv63333_test.diff, #53937
        Attached File- Added sv63333_fix.diff, #53938

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-02a9.
    Corresponding source code