bugmake - Bugs: bug #60378, Avoid duplicates in...

 
 

bug #60378: Avoid duplicates in default_include_directories.

Submitter:  Dmitry Goncharov <dgoncharov>
Submitted:  Mon 12 Apr 2021 01:19:21 AM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.4 Operating System:  POSIX-Based
Fixed Release:  4.4 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 17 Apr 2021 10:01:13 PM UTC, comment #2: 

I applied this change, lightly edited.  I'll push it to Git shortly.

Paul D. Smith <psmith>
Group administrator
Mon 12 Apr 2021 01:23:38 AM UTC, comment #1: 

The patch in the attachments compares the value of prefix with one of the hardcoded defaults of default_include_directories and defines INCLUDEDIR only if the specified prefix is different.

Dmitry Goncharov <dgoncharov>
Mon 12 Apr 2021 01:19:21 AM UTC, original submission:  

When the user does not specify --prefix, the default value often matches one of the hardcoded defaults in default_include_directories.
This results in a duplicate entry in default_include_directories.  This in turn results in make doing extra work looking for included file in the same directory twice.

Dmitry Goncharov <dgoncharov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dgoncharov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-04-17 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.4
        Triage StatusNone Small Effort
    2021-04-12 dgoncharov Attached File- Added sv60378_no_dups_in_default_include_directories.diff, #51247

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code