bugmake - Bugs: bug #32567, make can not compile anymore on...

 
 

bug #32567: make can not compile anymore on WINDOWS32 target from 2010-11-07

Submitter:  Dongsheng Song <cauchy>
Submitted:  Tue 22 Feb 2011 06:56:56 AM UTC
   
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.0 Operating System:  MS Windows
Fixed Release:  4.0 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 14 Nov 2011 12:59:59 AM UTC, comment #1: 

Fix committed to CVS.  Thanks.

Paul D. Smith <psmith>
Group administrator
Tue 22 Feb 2011 06:56:56 AM UTC, original submission:  

r1.211 (2010-11-07) break the building:

----------------------------
revision 1.211
date: 2010-11-07 05:56:24 +0800;  author: psmith;  state: Exp;  lines: +23 -9;
commitid: mcFNiET4DNlmJpVu;
Improve backslash/newline handling to adhere to POSIX requirements.
----------------------------

Here is the patch:

Index: job.c
===================================================================
RCS file: /sources/make/make/job.c,v
retrieving revision 1.211
diff -u -p -r1.211 job.c
--- job.c 6 Nov 2010 21:56:24 -0000 1.211
+++ job.c 22 Feb 2011 06:14:45 -0000
@@ -2990,7 +2990,7 @@ construct_command_argv_internal (char *l
       new_argv = xmalloc(2 sizeof (char ));
       new_argv[0] = xstrdup ("");
       new_argv[1] = NULL;
-    } else if ((no_default_sh_exe || batch_mode_shell) && batch_filename_ptr) {
+    } else if ((no_default_sh_exe || batch_mode_shell) && batch_filename_p) {
       int temp_fd;
       FILE* batch = NULL;
       int id = GetCurrentProcessId();
@@ -2998,10 +2998,10 @@ construct_command_argv_internal (char *l
 
       /* create a file name */
       sprintf(fbuf, "make%d", id);
-      *batch_filename_ptr = create_batch_file (fbuf, unixy_shell, &temp_fd);
+      *batch_filename_p = create_batch_file (fbuf, unixy_shell, &temp_fd);
 
       DB (DB_JOBS, (_("Creating temporary batch file %s\n"),
-                    *batch_filename_ptr));
+                    *batch_filename_p));
 
       /* Create a FILE object for the batch file, and write to it the
  commands to be executed.  Put the batch file in TEXT mode.  */
@@ -3019,9 +3019,9 @@ construct_command_argv_internal (char *l
       new_argv = xmalloc(3 sizeof (char ));
       if (unixy_shell) {
         new_argv[0] = xstrdup (shell);
-        new_argv[1] = batch_filename_ptr; / only argv[0] gets freed later */
+        new_argv[1] = batch_filename_p; / only argv[0] gets freed later */
       } else {
-        new_argv[0] = xstrdup (*batch_filename_ptr);
+        new_argv[0] = xstrdup (*batch_filename_p);
         new_argv[1] = NULL;
       }
       new_argv[2] = NULL;

Dongsheng Song <cauchy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by cauchy (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-11-14 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Operating SystemNone MS Windows
        Fixed ReleaseNone 4.0
    2011-02-22 cauchy Attached File- Added job.c.patch, #22751

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code